fix 提升锁的作用域 并采用双重校验锁

Signed-off-by: fanc <1571025887@qq.com>
This commit is contained in:
fanc 2024-01-25 06:48:29 +00:00 committed by Gitee
parent 7c5898ddf6
commit cb913a9adc
No known key found for this signature in database
GPG Key ID: 173E9B9CA92EEF8F

View File

@ -25,6 +25,8 @@ public class OssFactory {
private static final Map<String, OssClient> CLIENT_CACHE = new ConcurrentHashMap<>(); private static final Map<String, OssClient> CLIENT_CACHE = new ConcurrentHashMap<>();
private static final ReentrantLock lock = new ReentrantLock();
/** /**
* 获取默认实例 * 获取默认实例
*/ */
@ -51,12 +53,14 @@ public class OssFactory {
OssClient client = CLIENT_CACHE.get(key); OssClient client = CLIENT_CACHE.get(key);
// 客户端不存在或配置不相同则重新构建 // 客户端不存在或配置不相同则重新构建
if (client == null || !client.checkPropertiesSame(properties)) { if (client == null || !client.checkPropertiesSame(properties)) {
ReentrantLock lock = new ReentrantLock();
lock.lock(); lock.lock();
try { try {
CLIENT_CACHE.put(key, new OssClient(configKey, properties)); client = CLIENT_CACHE.get(key);
log.info("创建OSS实例 key => {}", configKey); if (client == null || !client.checkPropertiesSame(properties)) {
return CLIENT_CACHE.get(key); CLIENT_CACHE.put(key, new OssClient(configKey, properties));
log.info("创建OSS实例 key => {}", configKey);
return CLIENT_CACHE.get(key);
}
} finally { } finally {
lock.unlock(); lock.unlock();
} }